Feat/new architecture #103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntEnd interface accordingly
… getMapProcessingData methods
jim-bcom
approved these changes
Apr 25, 2025
| @@ -76,6 +76,7 @@ enum class FrameworkReturnCode:long{ | |||
| _LICENSE_MAX_CLIENTS_RELOC_EXCEEDED = -46, | |||
| _LICENSE_MAX_CLIENTS_STEREO_MAPPING_EXCEEDED = -47, | |||
| _LICENSE_MAX_CLIENTS_DENSE_MAPPING_EXCEEDED = -48, | |||
| _LICENSE_MAX_CLIENTS_STRUCTURE_FROM_MOTION_EXCEEDED = -49, | |||
There was a problem hiding this comment.
warning: we reached the limit here
| /// * FrameworkReturnCode::_SUCCESS if the map information is available | ||
| /// * FrameworkReturnCode::_UNKNOWN_MAP_UUID if mapUUID is unkown | ||
| /// * else FrameworkReturnCode::_ERROR_ | ||
| virtual FrameworkReturnCode getMapInfo(const std::string & mapUUID, |
There was a problem hiding this comment.
nit: not for now, but what about defining a MapInfo struct? This would allow to add more things in it without modifying the signature of getMapInfo() methods.
There was a problem hiding this comment.
I agree with this: to keep in mind
Minipeps
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.