[BUG]: .text-glow CSS rule at line 1178 overrides dark-mode neon glow globally — removed duplicate#991
Merged
Conversation
Unscoped .text-glow at line 1178 overrode the dark-mode cyan glow (rgba(0,240,255,0.7)) globally with a weaker blue shadow. Removed the duplicate since the light-theme scoped version already exists. Closes Somil450#936
|
@vipul674 is attempting to deploy a commit to the somiljain2024-4175's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@Somil450 Please review this PR. |
Somil450
added
gssoc-26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two competing
.text-glowdeclarations exist insrc/index.css. The one at line 1178 was NOT scoped to a theme, so it globally overrode the cyan dark-mode glow (0,0 20px rgba(0,240,255,0.7)) with a weaker blue shadow.Fix
Removed the duplicate unscoped
.text-glowrule at line 1178. The properly scoped version at line 1106 ([data-theme-style="light"] .text-glow) already handles light mode.Closes #936