[BUG]: skeletalSense.analyze() crashes with TypeError when nose landmark (index 0) is missing/undefined#992
Open
vipul674 wants to merge 1 commit into
Open
Conversation
landmarks[0] (nose) accessed without null check — throws TypeError when landmark is missing/undefined during pose detection gaps. Closes Somil450#937
|
@vipul674 is attempting to deploy a commit to the somiljain2024-4175's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@Somil450 Please review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
skeletalSense.analyze()at line 172 accesseslandmarks[0].ywithout checking iflandmarks[0]exists. When MediaPipe fails to detect the nose landmark (common during partial occlusions), this throwsTypeError: Cannot read properties of undefined.Fix
Added null guard (
landmarks[0] &&) before the conditional accessinglandmarks[0].y.Changes
src/services/skeletalSense.ts: One-line fix adding null checkCloses #937