Skip to content

[BUG]: syncOfflineQueue silently skips ALL sessions when user is not authenticated — queued data orphaned forever #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Somil450 merged 2 commits into from
Jul 9, 2026
+6 −2
Merged

[BUG]: syncOfflineQueue silently skips ALL sessions when user is not authenticated — queued data orphaned forever #994

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a527411
fix: throw on unauthenticated user in syncOfflineQueue
vipul674 Jun 27, 2026
299caa3
Merge branch 'main' into fix/939-syncofflinequeue-auth-check
Somil450 Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/services/syncQueue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,16 @@ async function uploadReplaySession(session: ReplaySession): Promise<void> {
*/
export async function syncOfflineQueue(): Promise<SyncResult> {
const currentUserId = getAuth().currentUser?.uid;
const queue = await getQueue();
if (!currentUserId) {
throw new Error("User not authenticated — cannot sync offline queue");
}

const queue = getQueue();
let synced = 0;
let failed = 0;

for (const session of queue) {
if (!currentUserId || session.userId !== currentUserId) {
if (session.userId !== currentUserId) {
continue;
}
try {
Expand Down
Loading