[BUG]: CRDT persistUpdate silently loses Yjs updates on IndexedDB read/write failure — missing error handlers#995
Open
vipul674 wants to merge 1 commit into
Conversation
persistUpdate was fire-and-forget with no rejection path for IDB errors. Missing onerror handlers for getReq and tx could silently lose Yjs updates on IndexedDB read/write failure. Closes Somil450#940
|
@vipul674 is attempting to deploy a commit to the somiljain2024-4175's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@Somil450 Please review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
persistUpdatereturned a Promise that never resolved or rejected (fire-and-forget). Missingonerrorhandlers forgetReq,putReq, and the transaction meant IDB failures silently swallowed Yjs updates.Fix
Promise<void>that resolves ontx.oncompleteonerrorhandlers forgetReq,putReq, andtxChanges
src/services/crdtSessionEngine.ts: Promise-wrapped persistUpdate with full error handlingCloses #940