Skip to content

fix: respect server default certification domain#30

Merged
SonJH7 merged 1 commit into
feature/KAN-116-goole-loginfrom
investigate-email-certification-conflict
Nov 6, 2025
Merged

fix: respect server default certification domain#30
SonJH7 merged 1 commit into
feature/KAN-116-goole-loginfrom
investigate-email-certification-conflict

Conversation

@SonJH7
Copy link
Copy Markdown
Owner

@SonJH7 SonJH7 commented Nov 6, 2025

Summary

  • avoid appending the default school domain on the client when sending certification requests so the backend can handle it
  • keep validating custom domains while omitting the domain field when the default domain is assumed
  • stop flagging local-part-only entries as invalid in the email input

Testing

  • npm run test -- src/tests/certification/EmailCertPage.test.tsx
  • npm run test -- src/tests/api/certification.requestEmail.test.ts

https://chatgpt.com/codex/tasks/task_e_690cd3c4f70c83328ee5022aeff87c15

@SonJH7 SonJH7 merged commit ce116ed into feature/KAN-116-goole-login Nov 6, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant