Add gzip compression for responses larger than 1KB#448
Open
ayo-ola0710 wants to merge 1 commit intoSoroScan:mainfrom
Open
Add gzip compression for responses larger than 1KB#448ayo-ola0710 wants to merge 1 commit intoSoroScan:mainfrom
ayo-ola0710 wants to merge 1 commit intoSoroScan:mainfrom
Conversation
- Created ConditionalGZipMiddleware extending GZipMiddleware - Configured middleware to only compress responses > 1KB - Added ConditionalGZipMiddlewareTests to verify compression logic
|
@ayo-ola0710 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
Implements gzip compression for REST and GraphQL responses to reduce network payload size (#320).
🚀 What was done
ConditionalGZipMiddlewareindjango-backend/soroscan/middleware.py.GZipMiddlewareto cleanly leverage standard compression logic while enforcing our specific threshold.MIDDLEWARElist insettings.pyso it processes responses late in the request lifecycle.🧠 Key Logic
1KB. Small responses bypass the compression step to avoid CPU overhead and the situation where compression increases the payload size.Content-Encodingheader has already been set.Accept-Encoding: gziprequirement seamlessly.🧪 Tests
test_compresses_large_response: Verifies responses > 1KB get gzipped and have the correct headers.test_does_not_compress_small_response: Ensures responses < 1KB remain uncompressed to avoid performance impact.test_does_not_compress_if_already_compressed: Guarantees we do not double-compress an already gzipped response.Closes #320