refactor(transaction): fix #287 by deleting empty stub file simulateTransaction.ts - #341
Merged
Conversation
|
@Gezziy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #287
Summary
This PR resolves issue #287 by deleting the empty stub file
src/transaction/simulateTransaction.ts. The stub file was misleading developers looking for pre-flight simulation logic and polluting workspace searches. It has been replaced with a comment insrc/transaction/index.tspointing developers to the correct location (src/soroban/simulateTransaction.tsorclient.soroban.simulate()).We have verified that no other files in the codebase import from
src/transaction/simulateTransaction.ts.Changes Made
src/transaction/simulateTransaction.ts(resolves src/transaction/simulateTransaction.ts Is an Empty Stub File That Misleads Contributors Searching for Simulation Logic #287)src/transaction/index.ts(resolves src/transaction/simulateTransaction.ts Is an Empty Stub File That Misleads Contributors Searching for Simulation Logic #287)Import Verification
We performed a workspace grep search for
simulateTransactionand confirmed that all active imports and invocations referencesrc/soroban/simulateTransaction.tsorclient.soroban.simulate(). No imports are broken by deleting this file.Testing
Verified that typecheck and build pass successfully:
npm run typecheck && npm run buildOutput: