Skip to content

refactor(transaction): fix #287 by deleting empty stub file simulateTransaction.ts - #341

Merged
k-deejah merged 7 commits into
Sorokit:mainfrom
Gezziy:empty-stub
Jul 28, 2026
Merged

refactor(transaction): fix #287 by deleting empty stub file simulateTransaction.ts#341
k-deejah merged 7 commits into
Sorokit:mainfrom
Gezziy:empty-stub

Conversation

@Gezziy

@Gezziy Gezziy commented Jul 28, 2026

Copy link
Copy Markdown

closes #287

Summary

This PR resolves issue #287 by deleting the empty stub file src/transaction/simulateTransaction.ts. The stub file was misleading developers looking for pre-flight simulation logic and polluting workspace searches. It has been replaced with a comment in src/transaction/index.ts pointing developers to the correct location (src/soroban/simulateTransaction.ts or client.soroban.simulate()).

We have verified that no other files in the codebase import from src/transaction/simulateTransaction.ts.

Changes Made

Import Verification

We performed a workspace grep search for simulateTransaction and confirmed that all active imports and invocations reference src/soroban/simulateTransaction.ts or client.soroban.simulate(). No imports are broken by deleting this file.

Testing

Verified that typecheck and build pass successfully:

npm run typecheck && npm run build

Output:

DTS ⚡️ Build success in 3183ms
ESM ⚡️ Build success in 3722ms
CJS ⚡️ Build success in 3722ms

@drips-wave

drips-wave Bot commented Jul 28, 2026

Copy link
Copy Markdown

@Gezziy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@k-deejah
k-deejah merged commit e993a27 into Sorokit:main Jul 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

src/transaction/simulateTransaction.ts Is an Empty Stub File That Misleads Contributors Searching for Simulation Logic

3 participants