feat(TransactionHistory): link each row to Stellar Expert for the active network (#340) - #386
Open
RUKAYAT-CODER wants to merge 1 commit into
Open
Conversation
…ive network (Sorokit#340) Issue Sorokit#340 flags that TransactionHistory rows had no deep link out to Stellar Expert. Each hash cell (both the desktop table and the mobile md:hidden card list) now renders an <a data-txhash href> targeting https://stellar.expert/explorer/{public|testnet}/tx/{hash} when the active Sorokit network is mainnet or testnet; for futurenet / localnet / null networks the row keeps the plain <span> fallback. A small local explorerTxUrl helper is added (mirrors the same helper already used by TransactionPanel.tsx) and `network` is added to the useSorokit destructure so the link can pick the right explorer segment. The link uses target=\"_blank\" rel=\"noreferrer\" with hover:underline and brand-color on hover. Closes Sorokit#340
|
@RUKAYAT-CODER Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wraps every
data-txhashcell inTransactionHistoryTable(desktop table and mobile card list) with an<a href>deep link tohttps://stellar.expert/explorer/{public|testnet}/tx/{hash}when the active Sorokit network ismainnetortestnet. Forfuturenet,localnet, or a null network the row still renders as a plain<span>because Stellar Expert does not index those.What changed
explorerTxUrl(network, hash)helper added (mirrors the same helper that already exists inTransactionPanel.tsx).networkis now pulled offuseSorokit()alongsideaddress/isConnected.<a data-txhash target="_blank" rel="noreferrer">when a URL resolves;<span data-txhash>otherwise.Notes
hover:underline text-brand; anaria-hiddenarrow glyph (↗) hints at external destination without affecting screen readers, since thetarget="_blank"+rel="noreferrer"attributes already advertise the link semantics.Closes #340