Skip to content

feat(ContractEventFeed): announce Export JSON count to screen readers, document fromLedger (#341) #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oladev2026-tech wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ContractEventFeed): announce Export JSON count to screen readers, document fromLedger (#341) #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/components/ContractEventFeed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,12 @@ export interface ContractEventFeedProps {
filterTypes?: string[];
/** Character length before an event value is truncated with a "Show more" toggle. */
maxValueLength?: number;
/** Optional start ledger to fetch events from. */
/**
* Optional start ledger to fetch events from. When omitted, the feed
* requests the latest events from the network's current ledger. When set,
* `getEvents(...)` is called with this value as the third argument so
* consumers can page through historical event windows.
*/
fromLedger?: number;
}

Expand Down Expand Up @@ -348,6 +353,7 @@ export function ContractEventFeed({
}}
disabled={events.length === 0}
title="Export JSON"
aria-label={`Export ${events.length} event${events.length === 1 ? "" : "s"} as JSON`}
className="px-2 py-1 rounded-lg text-[11px] font-semibold bg-surface-2 hover:bg-surface-3 text-ink-2 border border-line transition-colors disabled:opacity-40"
>
Export JSON
Expand Down