issue: 349, 354, 355, 356 - #390
Open
OSEH-svg wants to merge 1 commit into
Open
Conversation
|
@OSEH-svg Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #349
closes #354
closes #355
closes #356
changes made
[ErrorBoundary.tsx] now accepts an optional support link, surfaces the component stack in development mode, and keeps the fallback scoped when requested.
TransactionsScreen.tsx and SorobanScreen.tsx now wrap the high-risk panels with isolated error boundaries so one panel failure no longer crashes the whole screen.
Skeleton.tsx now supports square/circle/rounded shapes, a count-based row renderer, and a custom header slot for cards.
FeeEstimator.tsx and index.ts now support the compact layout, the fee-load callback, and export the standalone fee cell.
The TransactionPanel defaults/callbacks/memo-counter behavior from the first issue was already present in this workspace, and I verified it through the component tests.
Verification
I verified the work with:
npm test -- --run TransactionPanel.test.tsx ErrorBoundary.test.tsx FeeEstimator.test.tsx
Result:
3 test files passed
47 tests passed