Skip to content

add support for jsonb fields #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add support for jsonb fields #53

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dcaf75
add support for jsonb fields
madhums Oct 23, 2024
6a77cb8
fix indentation
madhums Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/administrate_exportable/exporter_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ def record_attribute(record, attribute_key, attribute_type)
field.truncate
when Administrate::Field::Time.to_s
field.data.strftime("%I:%M%p").to_s if field.data
when Administrate::Field::JSONB.to_s
field.to_json
else
field.to_s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does field.to_s below produce the same output?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I get an Administrate object.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this fix would make sense to me. Would this need to be included as a dependency?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, yes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'm not sure it makes sense to do.

end
Expand Down