[T-Only] Add android.hardware.power-V3-ndk to VndkMustUseVendorVarian…#7
Open
DigiGoon wants to merge 1 commit intoSpark-Rom:pyro-nextfrom
Open
[T-Only] Add android.hardware.power-V3-ndk to VndkMustUseVendorVarian…#7DigiGoon wants to merge 1 commit intoSpark-Rom:pyro-nextfrom
DigiGoon wants to merge 1 commit intoSpark-Rom:pyro-nextfrom
Conversation
…tList 8550 uses the AIDL V3 PowerHAL. Qualcomm must be disabling build restrictions because the below error occurs in LA.QSSI.13.0.r1. FAILED: out/target/product/spes/obj/SHARED_LIBRARIES/android.hardware.power-V3-ndk.vendor_intermediates/same_vndk_variants.timestamp /bin/bash -c "(CLANG_BIN=\"prebuilts/clang/host/linux-x86/clang-r450784d/bin\" CROSS_COMPILE=\"prebuilts/clang/host/linux-x86/clang-r450784d/bin/llvm-\" XZ=\">ERROR: VNDK library android.hardware.power-V3-ndk has different core and vendor variants! This means that the copy used in the system.img/etc and vendor.img/e> ERROR: 1). Remove differences, possibly using the libvndksupport function android_is_in_vendor_process in order to turn this into a runtime difference. ERROR: 2). Add the library to the VndkMustUseVendorVariantList variable in build/soong/cc/config/vndk.go, which is used to acknowledge this difference. This is expected because vendor versions of AIDL are by default different from core versions per https://android.googlesource.com/platform/build/soong/+/43b2c668da97601f828c7a42001147181a83449e%5E%21/#F0 There are a number of commits in AOSP master that will prevent this compilation error, however, to minimize risk on T, we will match the V2 and V1 behavior. Signed-off-by: Pranav Temkar <[email protected]> Change-Id: If47fed934a8d26ac9515012a02dd188c88ca18b2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tList
8550 uses the AIDL V3 PowerHAL. Qualcomm must be disabling build restrictions because the below error occurs in LA.QSSI.13.0.r1.
FAILED: out/target/product/spes/obj/SHARED_LIBRARIES/android.hardware.power-V3-ndk.vendor_intermediates/same_vndk_variants.timestamp
/bin/bash -c "(CLANG_BIN="prebuilts/clang/host/linux-x86/clang-r450784d/bin" CROSS_COMPILE="prebuilts/clang/host/linux-x86/clang-r450784d/bin/llvm-" XZ=">ERROR: VNDK library android.hardware.power-V3-ndk has different core and vendor variants! This means that the copy used in the system.img/etc and vendor.img/e>
ERROR: 1). Remove differences, possibly using the libvndksupport function android_is_in_vendor_process in order to turn this into a runtime difference.
ERROR: 2). Add the library to the VndkMustUseVendorVariantList variable in build/soong/cc/config/vndk.go, which is used to acknowledge this difference.
This is expected because vendor versions of AIDL are by default different from core versions per
https://android.googlesource.com/platform/build/soong/+/43b2c668da97601f828c7a42001147181a83449e%5E%21/#F0
There are a number of commits in AOSP master that will prevent this compilation error, however, to minimize risk on T, we will match the V2 and V1 behavior.
Change-Id: If47fed934a8d26ac9515012a02dd188c88ca18b2