Skip to content

Conversation

JonasBK
Copy link
Contributor

@JonasBK JonasBK commented Aug 6, 2025

Description

Collection of additional CA reg key value (RPC encryption enforcement)

Motivation and Context

This change is required for ADCS ESC11 coverage.

Corresponding SHC PR: SpecterOps/SharpHoundCommon#239
Corresponding BHCE PR: SpecterOps/BloodHound#1679

Resolves BED-6182

How Has This Been Tested?

Locally in lab.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Summary by CodeRabbit

  • New Features
    • Added display of RPC encryption enforcement status for Certificate Authorities.

@JonasBK JonasBK self-assigned this Aug 6, 2025
@JonasBK JonasBK added enhancement New feature or request external This pull request is from an external contributor blocked by SHC PR A SharpHoundCommon PR must be merged in first before this PR labels Aug 6, 2025
Copy link

coderabbitai bot commented Aug 6, 2025

Walkthrough

A new boolean variable and a property related to RPC encryption enforcement were added within the ProcessEnterpriseCA method in ObjectProcessors.cs. The new property is stored in the CARegistryData object, and its collection status is tracked in the properties dictionary.

Changes

Cohort / File(s) Change Summary
ProcessEnterpriseCA Enhancements
src/Runtime/ObjectProcessors.cs
Added a variable to track RPC encryption collection, introduced a new property for RPC encryption enforcement, updated property assignment, and added the flag to the properties dictionary.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

In ObjectProcessors, changes hop,
With braces neat from top to top.
Encryption checks now clearly tracked,
Properties in order, nothing lacked.
A bunny's nod to code refined,
Secure and tidy, well-aligned!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6336630 and 43e87c2.

📒 Files selected for processing (1)
  • src/Runtime/ObjectProcessors.cs (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/Runtime/ObjectProcessors.cs
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch esc11

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked by SHC PR A SharpHoundCommon PR must be merged in first before this PR enhancement New feature or request external This pull request is from an external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant