Initial NTLM Implementation #177
Conversation
|
recheck |
# Conflicts: # src/CommonLib/LdapConnectionPool.cs
| throw new ArgumentException("Url property is null"); | ||
|
|
||
| if (useBadChannelBindings == null && url.Scheme == "https") | ||
| throw new ArgumentException("When using HTTPS, useBadChannelBindings must be set"); |
There was a problem hiding this comment.
Nitpicking, but trinary args like this tend to create some funky logic flows that can be hard to follow if you're smooth-brained like I am.
Here I think we're taking on some complexity by managing arg validations that the callers could be doing instead.
I might split this into two functions for clarity: the public function that does everything up to this point, then a private EnsureRequiresAuth(Uri url, bool useBadChannelBindings) that this one calls, feeding the appropriate coerced useBadChannelBindings:
EnsureRequiresAuth(url, useBadChannelBindings ?? true);
| return schemes; | ||
| } | ||
|
|
||
| private async Task AuthWithBadChannelBindings(Uri url, string authScheme) { |
There was a problem hiding this comment.
Could use "-Async" suffix
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| namespace SharpHoundCommonLib.OutputTypes | |||
| { | |||
| public class AceRegistryAPIResult : APIResult | |||
| public class AceRegistryAPIResult : APIResult.APIResult | |||
There was a problem hiding this comment.
Prefer the namespace and class had different names but not a blocker
| public TypedPrincipal[] AllowedToAct { get; set; } = Array.Empty<TypedPrincipal>(); | ||
| public TypedPrincipal[] HasSIDHistory { get; set; } = Array.Empty<TypedPrincipal>(); | ||
| public TypedPrincipal[] DumpSMSAPassword { get; set; } = Array.Empty<TypedPrincipal>(); | ||
| public TypedPrincipal[] AllowedToDelegate { get; set; } = []; |
There was a problem hiding this comment.
This syntax may not compile with older dotnet sdks
There was a problem hiding this comment.
Looks like this syntax feature isn't available til dotnet 8
Feature 'collection expressions' is not available in C# 11.0. Please use language version 12.0 or greater.
There was a problem hiding this comment.
Thanks dotnet fiddle
Description
This is the initial implementation of the new NTLM modelling, courtesy of @leechristensen .
Motivation and Context
https://specterops.atlassian.net/browse/BED-5113
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: