Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-1232] Add test coverage for LdapConnectionPool excluded domains #182

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

definitelynotagoblin
Copy link
Contributor

Description

And correct use of dotnet preview feature use on LdapUtils

Motivation and Context

https://specterops.atlassian.net/browse/BP-1232

Adding test coverage for excluded domains, and correcting the use of a preview feature in LdapUtils that can cause build trouble.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@rvazarkar rvazarkar merged commit fea568a into v4 Feb 21, 2025
3 checks passed
@rvazarkar rvazarkar deleted the excluded-domains-tests branch February 21, 2025 21:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants