Skip to content

Conversation

MikeX777
Copy link
Contributor

@MikeX777 MikeX777 commented Aug 26, 2025

Adds additional information for a newly collected field on GPOs in SharpHound that will be ingested into BloodHound.

To be merged after the following are released:
SpecterOps/BloodHound#1825
https://github.com/SpecterOps/bloodhound-enterprise/pull/599

Summary by CodeRabbit

  • Documentation
    • Added “GPO Status” to the Node properties documentation, describing the status at the time of collection.
    • Enumerates possible values: Enabled, User Configuration Disabled, Computer Configuration Disabled, and Disabled.
    • Improves clarity for users interpreting GPO status in node details.
    • No functional changes to the product.

@MikeX777 MikeX777 self-assigned this Aug 26, 2025
@MikeX777 MikeX777 added the documentation Improvements or additions to documentation label Aug 26, 2025
Copy link
Contributor

coderabbitai bot commented Aug 26, 2025

Walkthrough

Adds a new “GPO Status” row to the Node properties table in docs/resources/nodes/gpo.mdx, documenting possible values and clarifying it reflects status at collection time. No code or behavior changes.

Changes

Cohort / File(s) Summary of Changes
Docs: GPO Node Properties
docs/resources/nodes/gpo.mdx
Added a “GPO Status” table row listing possible status values: “Enabled”, “User Configuration Disabled”, “Computer Configuration Disabled”, “Disabled”. Documentation-only update.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitched my nose at docs so bright,
A status row hopped into sight—
Enabled, disabled, clear as day,
User, computer, neatly laid.
I thump in joy, no code to test,
Just carrots, tables—documentation’s best! 🥕

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7cff341 and 802b812.

📒 Files selected for processing (1)
  • docs/resources/nodes/gpo.mdx (1 hunks)
🔇 Additional comments (1)
docs/resources/nodes/gpo.mdx (1)

25-25: Typo fix and value-label verification

I’ve corrected the spelling of “Configuration” and wrapped each status in backticks for clarity. Please confirm that these labels exactly match what SharpHound emits; if SharpHound uses the “All settings …” variants, swap in the alternate list below.

• Location: docs/resources/nodes/gpo.mdx, line 25

Proposed change:

-| GPO Status | The status of the GPO at the time of collection. Can have the values of "Enabled", "User Configruation Disabled", "Computer Configuration Disabled", and "Disabled".    |
+| GPO Status | The status of the GPO at the time of collection. Possible values: `Enabled`, `User Configuration Disabled`, `Computer Configuration Disabled`, `Disabled`. |

Alternate (if SharpHound outputs the “All settings …” phrasing):

-| GPO Status | The status of the GPO at the time of collection. Can have the values of "Enabled", "User Configruation Disabled", "Computer Configuration Disabled", and "Disabled".    |
+| GPO Status | The status of the GPO at the time of collection. Possible values: `All settings enabled`, `User configuration settings disabled`, `Computer configuration settings disabled`, `All settings disabled`. |
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mcuomo/BED-6027

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@StephenHinck StephenHinck added the Waiting for BH PR Don't merge this doc update until the related BH feature is merged and released. label Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Waiting for BH PR Don't merge this doc update until the related BH feature is merged and released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants