Skip to content

Address memory management in hashlib#7

Draft
Xor-el wants to merge 3 commits intomasterfrom
address-memory-management-in-hashlib
Draft

Address memory management in hashlib#7
Xor-el wants to merge 3 commits intomasterfrom
address-memory-management-in-hashlib

Conversation

@Xor-el
Copy link
Contributor

@Xor-el Xor-el commented Dec 4, 2022

No description provided.

@HermanSchoenfeld
Copy link
Contributor

HermanSchoenfeld commented Dec 6, 2022

I think you should not link to Hydrogen and simply duplicate the code you need. HashLib4CSharp is an independent library and the code should be maintained that way. I do not wish to have a fork of HashLib4CSharp and prefer to have an active mirror of it. Probably later we'll just use a Nuget package to it.

Also, IHash being an IDisposable is good but now all usage of it must be updated to ensure instances are disposed. As discussed, a simple approach to this cumbersome task is to replace all usage

IHash varName = SomeWayToGetInstanceOfIHash();

to

using IHash varName = SomeWayToGetInstanceOfIHash();

@Xor-el
Copy link
Contributor Author

Xor-el commented Dec 7, 2022

Duly noted.
will implement as discussed, thanks.

@HermanSchoenfeld
Copy link
Contributor

Hi Ugo, are you able to get this PR compiling? Apologies for not integrating it before.

@Xor-el
Copy link
Contributor Author

Xor-el commented Sep 27, 2023

Hello Herman, I just merged the latest master to this branch.
CI pipeline is currently running.
please do note that the current master build has a test that is failing in the pipeline, maybe you can look into this?

@HermanSchoenfeld HermanSchoenfeld force-pushed the master branch 2 times, most recently from 0d80b3d to eace2bb Compare June 9, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants