Spms 235

[fritsbeumer]

Hi Niels,
Kun jij naar de testen kijken zodat het in development gemerged kan worden?

groet frits

[nklomp]

Please see remarks. Check formatting!

[nklomp]

Why is this test not a test anymore? Unless I am missing something

[nklomp]

Ok got it. As you have overrides for every method that simply delegates to the super anyway. Why not simply leave as is and remove all the overrides? Just make this class abstract

[nklomp]

Please adhere to "standard" coding rules in the project

[fritsbeumer]

Hi Niels, Ik heb jouw voorstel al geprobeerd (abstract maken vd de class) maar dan werkt de '@FixMethodOrder' niet meer omdat deze niet wordt overgeerfd. Dan wordt de '070_' methode gedraaid voor alle andere testen. Ik heb ook allerlei andere combinaties geprobeerd, bijv. abstract _70_checkGeneratedPdf() in een abstracte class met @test erboven, maar dit helpt ook niet. Dit was de enige manier om het te toen. Groet frits

________________________________ From: Niels Klomp <[email protected]> Sent: Tuesday, November 6, 2018 1:16:59 AM To: Sphereon-SDK/pdf-sdk Cc: Frits Beumer; Author Subject: Re: [Sphereon-SDK/pdf-sdk] Spms 235 (#4) @nklomp requested changes on this pull request. Please see remarks. Check formatting!

________________________________ In java8-okhttp-gson/src/test/java/com/sphereon/sdk/pdf/api/Conversion2PDFApiTest.java<#4 (comment)>:

/** * API tests for Conversion2PDFApi */ -@FixMethodOrder(MethodSorters.NAME_ASCENDING) Why is this test not a test anymore? Unless I am missing something

________________________________ In java8-okhttp-gson/src/test/java/com/sphereon/sdk/pdf/api/advanced/AdvCsvTifXmlConversion2PDFApiTest.java<#4 (comment)>:

+ super._040_getJob();

+ } + + @test + public void _050_getPDF() throws ApiException, InterruptedException { + super._050_getPDF(); + } + + @test + public void _060_deleteJob() throws ApiException { + super._060_deleteJob(); + } + + @test + public void _70_checkGeneratedPdf() throws IOException{ + if (WRITE_TO_FILE) Please adhere to "standard" coding rules in the project

________________________________ In java8-okhttp-gson/src/test/java/com/sphereon/sdk/pdf/api/Conversion2PDFApiTest.java<#4 (comment)>:

/** * API tests for Conversion2PDFApi */ -@FixMethodOrder(MethodSorters.NAME_ASCENDING) Ok got it. As you have overrides for every method that simply delegates to the super anyway. Why not simply leave as is and remove all the overrides? Just make this class abstract — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#4 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Ap7JgfVJISDjQJgjWmbYgUuMEMsqNpOiks5usNT7gaJpZM4X701T>.