-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typing of tests #1546
Open
Christian-B
wants to merge
40
commits into
master
Choose a base branch
from
mypy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
typing of tests #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectionHolder types updated to included list types.
"Values" TypeAlias used for setting PyNn values such as State Values and parameter Values updated to include a callable to go from int to a float.
The input types allowed for Weight and delays
spynnaker/pyNN/types.py
changed to allow NDArray of float.
removed "int" as float implies int
added a writer _get_id_counter test method
as hacking the data and adding an ignore in 80 characters was too tricky
Population / PopulationView all method type fixed.
weight_scales can be numpy array or Sequence of float
Type alias for mask used to create PopulationViews relaxed to accept any Sequence (for example a tuple)
spynnaker_integration_tests/test_additional_params_on_pop_not_recogonised/test_additional_params_mix.py
Changed to include the checking of logs
/home/brenninc/spinnaker/sPyNNaker/unittests/test_from_file_connector.py
replaced:
elif len(header):
f.write("# {}\n".format(header))
with:
else:
assert len(header) == 0
reason is the write of a string fails! but was never actually called!
numpy.array_equal can compare None to None even though mypy thinks it can not