Skip to content

Update/Fix for MaxWell systems #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

cmccrimmon
Copy link

Updated for current MaxWell systems - now utilize events to extract MAXWELL SPIKE (via built in template matching) and STIMULATION events. Also remove 1) instances where multiple MaxWell electrodes are connected to the same channel (mix of electrode signals) and 2) duplicates where multiple MaxWell channels and connected to the same electrode (duplicates) as discussed in NeuralEnsemble/python-neo#1703. Updated prior closed pull request #4015 to avoid pandas usage.

cmccrimmon and others added 12 commits June 26, 2025 18:18
Extract stimulation and Maxwell spike events
Remove duplicate channel_id assignments (preferentially keep earlier ids)
Removed duplicate removal temporarily
Remove 1) instances where multiple MaxWell electrodes are connected to the same channel (mix of electrode signals) and 2) duplicates where multiple MaxWell channels and connected to the same electrode (duplicates).
Significant update for MaxWell systems - now utilize events to extract MAXWELL SPIKE (via built in template matching) and STIMULATION events.
Avoids using pandas and fixed error with pop use
@alejoe91 alejoe91 added the extractors Related to extractors module label Jul 1, 2025
@alejoe91 alejoe91 added this to the 0.103.0 milestone Jul 3, 2025
@alejoe91 alejoe91 removed this from the 0.103.0 milestone Jul 17, 2025
@alejoe91
Copy link
Member

alejoe91 commented Aug 7, 2025

@cmccrimmon all tests fail, and I think it's because of the changes to neobase. Can you double check?

For the Maxwell part, @philipp-mxw can you review?

@philipp-mxw
Copy link
Contributor

When using the h5 file provided in one of the associated issues, it fails for me already before any of the changes are actually run

Exception has occurred: ValueError signal_channels do not have unique ids for stream 0 File "/home/phornauer/Code/spikeinterface/src/spikeinterface/extractors/neoextractors/neobaseextractor.py", line 66, in get_neo_io_reader neo_reader.parse_header() File "/home/phornauer/Code/spikeinterface/src/spikeinterface/extractors/neoextractors/neobaseextractor.py", line 27, in __init__ self.neo_reader = self.get_neo_io_reader(self.NeoRawIOClass, **neo_kwargs) File "/home/phornauer/Code/spikeinterface/src/spikeinterface/extractors/neoextractors/neobaseextractor.py", line 188, in __init__ _NeoBaseExtractor.__init__(self, block_index, **neo_kwargs) File "/home/phornauer/Code/spikeinterface/src/spikeinterface/extractors/neoextractors/maxwell.py", line 62, in __init__ NeoBaseRecordingExtractor.__init__( File "/home/phornauer/Code/support/debug_si.py", line 5, in <module> rec = se.MaxwellRecordingExtractor(file_path) ValueError: signal_channels do not have unique ids for stream 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extractors Related to extractors module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants