Refactors spin-wave calculation for parallelism #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhroom
force-pushed
the
42-parallelise-spinwave
branch
from
2ded2f6 to
3ecded8
Compare
alexhroom
changed the title
concurrent.futures.ProcessPoolExecutor
alexhroom
force-pushed
the
42-parallelise-spinwave
branch
from
3ecded8 to
f4b61c8
Compare
alexhroom
force-pushed
the
42-parallelise-spinwave
branch
from
99c02a8 to
023195d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the spin-wave calculation so that it can be parallelised over q. Currently it seems that the parallelism slows things down, so I've put it behind a global flag
PARALLELwhile we're still testing things - I'll put some benchmarks together to see if it's faster for a large example. We also get a modest speed improvement as it avoids recalculating theCmatrix for every q-value (it is q-independent) and also factors out the coupling-independent terms over sites.