-
Notifications
You must be signed in to change notification settings - Fork 136
adding genomad version 1.11.2 #1517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Accidentally started as a draft PR, but these files are ready for review. Sorry!!! |
|
Here's what was installed by pip:
|
|
There was an error regarding CUDA in the test, any idea if this needs to be resolved or not? I doubt this is running on a GPU, but I could be wrong. Database was downloaded successfully and tests passed (except for the cuda error): |
|
I think this error is from checking to see if CUDA is installed and working and switching it CPU-only if CUDA isn't found. I'm not planning on using CUDA with this image, but I think there is a way to suppress this error message. I'll convert this to draft until I have time to work on it. |
There's a new version of genomad!
According to the release notes there are some small improvements and version updates.
I copied the files from 1.11.1 and updated the version arg.
The full diff:
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)