-
Notifications
You must be signed in to change notification settings - Fork 136
adding abricate version 1.2.0 #1521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| # Grab test Vcholerae genome, uncompress, and save to /data | ||
| RUN wget -O - https://ftp.ncbi.nlm.nih.gov/genomes/all/GCA/018/083/565/GCA_018083565.2_PDT000793508.2/GCA_018083565.2_PDT000793508.2_genomic.fna.gz \ | ||
| | gunzip -c > /data/GCA_018083565.2_PDT000793508.2_genomic.fna |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove these 3 lines, they were for testing the custom V cholerae DB and are unnecessary here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept this one because this is a "real world" use-case. The rest of the tests use the toy data.
Updated example usage in README.md to include new commands and database options.
Removed redundant information about image rebuilding frequency.
|
I have removed the github action, because it was pointed out to me that the databases are downloaded from the github repo, so rebuilding every month won't be useful. |
|
The most recent github actions workflow had all the docker image layers cached, so here's the one where it rebuilt the image from scratch, everything passed ✅ https://github.com/StaPH-B/docker-builds/actions/runs/20724012532/job/59495003575 some of the last few lines of output to show success: |
|
Thanks for the PR! Deploy workflow here: https://github.com/StaPH-B/docker-builds/actions/runs/20824656459 |
There's a new version of abricate!
According to the release notes the database links are fixed and there are some new options.
Closes #1508
I copied the files from a prior version and updated the abricate version. I also updated the base image, added a CMD line, fixed the tests, and some other changes.
Also attached to this PR is a github action that will rebuild this image every month with whatever links abricate uses to download the databases.
The full diff:
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)