Skip to content

Allow any address holding the REVOKER_ROLE to revoke tokens #37 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shrilakshmikakati wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow any address holding the REVOKER_ROLE to revoke tokens #37 #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions contracts/src/TNT.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ contract TNT is ERC721, AccessControl {

function revokeToken(uint256 tokenId) public onlyRole(REVOKER_ROLE) {
if (!revokable) revert NotRevokable();
if (tokenIssuers[tokenId] != msg.sender) revert NotIssuer();

address tokenOwner = ownerOf(tokenId);
_removeFromActive(tokenOwner, tokenId);
Expand Down Expand Up @@ -146,4 +145,4 @@ contract TNT is ERC721, AccessControl {
function grantMinterRole(address account) public onlyRole(DEFAULT_ADMIN_ROLE) { grantRole(MINTER_ROLE, account); }
function grantRevokerRole(address account) public onlyRole(DEFAULT_ADMIN_ROLE) { grantRole(REVOKER_ROLE, account); }
function supportsInterface(bytes4 interfaceId) public view override(ERC721, AccessControl) returns (bool) { return super.supportsInterface(interfaceId); }
}
}