Following the guidelines in the file, refreshing this #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dist_utils.py in this repo according to the comments should be a near copy of the one in the st2 repo. I've copied it over (removed some comments specific to the st2 version) so that it can also stop breaking on requirements.txt that use the
;to separate python markers.This should fix the circleci tests on StackStorm/st2#6296 and future PRs once merged.
This is a bit of a catch22 situation.
This build pulls master of st2, which does not have my dist_utils fixes yet, so it fails. The st2 pulls the current master of this repo which doesn't have my changes yet and fails.
One of these probably has to be forced merged so the other tests with the changes?