Skip to content

Fix GUI limit issue for "Packs" and "Triggers" (cf. st2web issue #1034). #6360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TimothyDJones wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix GUI limit issue for "Packs" and "Triggers" (cf. st2web issue #1034). #6360

TimothyDJones wants to merge 4 commits into from

Conversation

@TimothyDJones
Copy link

@TimothyDJones TimothyDJones commented Oct 31, 2025 

Increase default for `limit` parameter to 500.

Default is increased for `packs` and `triggertypes` to fix
GUI problem with "panel" lists for "Packs" and "Triggers"
not displaying complete data due to current limit of 100,
when many packs and/or triggers are registered in ST2.

Update fixes `st2web` issue #1034.
https://github.com/StackStorm/st2web/issues/1034

@TimothyDJones
Update sensor wrapper to make list_values() method congruent with r…
b4351e8 
…egular datastore method. Specifically, support use of `limit` and `offset` parameters.
@TimothyDJones
Add change log comment for PR StackStorm#5913.
7c79e5e
@TimothyDJones
Increase default for limit parameter to 500.
82297ec 
Default is increased for `packs` and `triggertypes` to fix
GUI problem with "panel" lists for "Packs" and "Triggers"
not displaying complete data due to current limit of 100,
when many packs and/or triggers are registered in ST2.

Update fixes `st2web` issue StackStorm#1034.
StackStorm/st2web#1034
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Oct 31, 2025
@fdrab
Copy link
Contributor

fdrab commented Nov 1, 2025 •
edited
Loading

isn't this a configurable parameter in the configs?

# Maximum limit (page size) argument which can be specified by the user in a query string.
max_page_size = 100

fdrab
fdrab reviewed Nov 1, 2025
View reviewed changes
st2reactor/st2reactor/container/sensor_wrapper.py
##################################

def list_values(self, local=True, prefix=None, limit=None, offset=None):
def list_values(self, local=True, prefix=None, limit=None, offset=0):
Copy link
Contributor

@fdrab fdrab Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for datastore items. what are you trying to do here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fdrab fdrab fdrab left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

size/S PR that changes 10-29 lines. Very easy to review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimothyDJones @fdrab