Stop downloading unused curl #119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorpeshansky
requested changes
Feb 18, 2021
| @@ -17,13 +17,7 @@ CURL_VERSION=7.52.1 | |||
| endif | |||
| endif | |||
|
|
|||
| ifeq ($(filter sles%,$(DISTRO)),) # If DISTRO is not sles*. | |||
| vendor: | |||
| [ -f curl-$(CURL_VERSION).tar.bz2 ] || curl -O https://curl.haxx.se/download/curl-$(CURL_VERSION).tar.bz2 | |||
There was a problem hiding this comment.
We also have to fix all parts of the RPM spec that use bundle_curl (that's where this downloaded source is used).
|
Is the following still an issue? agent-packaging/rpm/stackdriver-agent.spec Lines 120 to 121 in 67eeef7 |
|
I removed the usage, what would be the next steps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sha1 of the downloaded curl is no longer matches the on in curl-7.34.0.sha1 (which seems suspicious). This PR stops downloading curl, as we don't seem to be using it