refactor: Code cleanup Pt1 #37
Conversation
Ninerian
commented
Oct 29, 2025
Ninerian
commented
- added code quality dependencies
- raised phpstan level to 5 and fixed all errors
- updated phpunit to 10
Ninerian
requested review from
Magnet-js and
MrLeonix
and removed request for
a team
Ninerian
force-pushed
the
code-cleanup
branch
from
e88e6fe to
3300537
Compare
- Updated phpstan.neon.dist to level 4 - Removed unused expressions in PluginSessionTest - Fixed always-true ternary in SSODataTest - Refined assertion in SSOTokenTest to avoid redundant type check - Removed unreachable code after markTestSkipped statements - Added proper assertions to make mock object usage meaningful 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Updated phpstan.neon.dist to level 5 - Fixed type parameter in HasInstanceId::hasInstanceId() method from Plain to UnencryptedToken - Removed unused Plain token import - Aligns with lcobucci/jwt library token type hierarchy 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Ninerian
force-pushed
the
code-cleanup
branch
from
acc47ef to
0ed5e27
Compare
| branches: | ||
| - 'main' | ||
| - '**/**' |
There was a problem hiding this comment.
What is the goal here? Why not just
| branches: | |
| - 'main' | |
| - '**/**' | |
| branches: | |
| - '**' |
| branches: | ||
| - 'main' | ||
| - '**/**' |
| * @see \Staffbase\plugins\sdk\SSOToken::CLAIM_AUDIENCE | ||
| */ | ||
| const CLAIM_AUDIENCE = 'aud'; | ||
| public const CLAIM_AUDIENCE = 'aud'; |
There was a problem hiding this comment.
Why do we want to switch to public when it is already marked as deprecated? 🤔
| $this->assertEquals($sessionId, session_id()); | ||
| } | ||
|
|
||
| public function testDestroyOtherSession() |
There was a problem hiding this comment.
What is the plan for this empty test?
| $session->destroySession($sessionHash); | ||
| } | ||
|
|
||
| public function testDestroyOwnSession() |
There was a problem hiding this comment.
What is the plan for this empty test?
| # CodeSniffer | ||
| phpcs.xml | ||
|
|
||
| /vendor/* |
There was a problem hiding this comment.
this one is already covered by line 13
There was a problem hiding this comment.
I'd love to have this information rather in .github/copilot-instructions.md
It would be cool to have some general file where all LLMs are looking into.
Since Claude itself is not (yet) company wide approved. It might be helpful for you to keep the CLAUDE.md on your machine and link the .github/copilot-instructions.md file in it where all the information is moved to.
