Skip to content

Warning timeout update#38

Open
brandonhenry wants to merge 19 commits intoalphafrom
warning-timeout-update
Open

Warning timeout update#38
brandonhenry wants to merge 19 commits intoalphafrom
warning-timeout-update

Conversation

@brandonhenry
Copy link
Copy Markdown
Collaborator

No description provided.

@brandonhenry brandonhenry self-assigned this Jun 9, 2019
Comment thread src/css/TitleBar.scss
#resize-button, #minimize-button {
&:hover {
background: silver;
background: rgba(128, 128, 128, 0.3);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like rgba(128, 128, 128, 0.3) should only be used in variable declarations; they should be referred to via variable everywhere else.

Comment thread src/css/TitleBar.scss
#close-button {
&:hover {
background: #e0021f;
background: #ff1938;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #ff1938 should only be used in variable declarations; they should be referred to via variable everywhere else.

Comment thread src/css/TitleBar.scss

&.theme-dark {
background: #252525;
background: rgba(0, 0, 0, 0.6);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like rgba(0, 0, 0, 0.6) should only be used in variable declarations; they should be referred to via variable everywhere else.

}
}

h5.scanning-text {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid qualifying class selectors with an element.

text-align: center;

&::before {
&:first-child::before {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule set contains (12/10) properties

Comment thread src/css/SongListItem.scss
white-space: nowrap;
text-overflow: ellipsis;
}
.upload-date {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector should have depth of applicability no greater than 2, but was 3

Comment thread src/css/SettingsView.scss
margin-bottom: 5px;
}

#dl-location, #theme-image-path {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using id selectors
Each selector in a comma sequence should be on its own single line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants