[BugFix]disable chunked upload in aws sdk while we have support it in poco #55854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
|
more reference aws/aws-sdk-cpp#3297 |
zombee0
force-pushed
the
support_express_one
branch
from
4ec7e9a to
05d4c03
Compare
|
@mergify rebase |
✅ Branch has been successfully rebased |
wangruin
force-pushed
the
support_express_one
branch
from
05d4c03 to
f62b2b4
Compare
zombee0
force-pushed
the
support_express_one
branch
2 times, most recently
from
603d9d2 to
64f0da0
Compare
|
@Mergifyio rebase |
… poco Signed-off-by: zombee0 <[email protected]>
Signed-off-by: zombee0 <[email protected]>
✅ Branch has been successfully rebased |
kevincai
force-pushed
the
support_express_one
branch
from
64f0da0 to
bafcaa2
Compare
kevincai
approved these changes
Feb 21, 2025
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
wangruin
approved these changes
Feb 21, 2025
|
@Mergifyio backport branch-3.4 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 21, 2025
… poco (#55854) Signed-off-by: zombee0 <[email protected]> (cherry picked from commit 48cc6fc)
Merged
18 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Feb 21, 2025
… poco (backport #55854) (#56170) Co-authored-by: zombee0 <[email protected]>
dyp12
pushed a commit
to dyp12/starrocks
that referenced
this pull request
Mar 5, 2025
… poco (StarRocks#55854) Signed-off-by: zombee0 <[email protected]> Signed-off-by: 00193254 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixing the issue when accessing S3 Express One
A community user reported an issue where they encountered an exception
while creating a table on S3 Express One. Based on our tests, the issue
occurs with PutObject, while MultiPartUpload works fine when accessing
S3 Express One.
The root cause is that, even when setting PayloadSigningPolicy::Never,
requests to S3 Express One still get signed. This results in chunked uploads,
which are not supported in the Poco client.
I think we can works around this by setting a checksum in the request,
preventing additional signing and avoiding chunked uploads. However,
applying this approach in our case would require setting a checksum
for all PutObject and MultiUpload requests across both starrocks_be
and staros, which is error-prone.
To address this more reliably, I propose disabling chunked uploads
via a patch to aws-cpp-sdk.
and once we supported chunked upload, we can remove this patch.
Fixes #issue
#55685
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: