Skip to content

refactor: update the auction mobile responsiveness#138

Merged
DioChuks merged 3 commits intoStarkBid:mainfrom
CMI-James-OD:refactor/update-collection-mobile-responsiveness
Aug 5, 2025
Merged

refactor: update the auction mobile responsiveness#138
DioChuks merged 3 commits intoStarkBid:mainfrom
CMI-James-OD:refactor/update-collection-mobile-responsiveness

Conversation

@CMI-James
Copy link
Contributor

@CMI-James CMI-James commented Aug 1, 2025

Description

Closes #127

Changes proposed

What were you told to do?

Tasked to improve the mobile responsiveness of the auction page

What did you do?

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

localhost_3000_auction(iPhone 14 Pro Max)

@netlify
Copy link

netlify bot commented Aug 1, 2025

Deploy Preview for starkbid-stable ready!

Name Link
🔨 Latest commit 98026b9
🔍 Latest deploy log https://app.netlify.com/projects/starkbid-stable/deploys/6890af0e65ea99000823daef
😎 Deploy Preview https://deploy-preview-138--starkbid-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 1, 2025

Deploy Preview for starkbid ready!

Name Link
🔨 Latest commit 98026b9
🔍 Latest deploy log https://app.netlify.com/projects/starkbid/deploys/6890af0e5aec260008b1ef56
😎 Deploy Preview https://deploy-preview-138--starkbid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@DioChuks DioChuks self-requested a review August 3, 2025 16:28
Copy link
Contributor

@DioChuks DioChuks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls ensure to attend to this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whatever u did here, also messed up the desktop UI

Original UI

image

your change

image

kindly fix or revert change

@DioChuks DioChuks marked this pull request as draft August 3, 2025 16:54
@CMI-James
Copy link
Contributor Author

Pls ensure to attend to this

alright thanks for the review, I will fix them right away.

@DioChuks
Copy link
Contributor

DioChuks commented Aug 4, 2025

Pls ensure to attend to this

alright thanks for the review, I will fix them right away.

no new changes since then, are you facing any problems?

@CMI-James CMI-James marked this pull request as ready for review August 4, 2025 13:01
@CMI-James
Copy link
Contributor Author

Pls ensure to attend to this

alright thanks for the review, I will fix them right away.

no new changes since then, are you facing any problems?

I have made the requested changes, kindly review

@CMI-James CMI-James changed the title refactor: update the collection mobile responsiveness refactor: update the auction mobile responsiveness Aug 4, 2025
@DioChuks DioChuks merged commit 46759d8 into StarkBid:main Aug 5, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement or Edit Auction Screen mobile responsiveness to match Figma design

2 participants