Skip to content

feat: Home page responsiveness#141

Merged
DioChuks merged 3 commits intoStarkBid:mainfrom
YakshitAgarwal:feat-120-home-page
Aug 12, 2025
Merged

feat: Home page responsiveness#141
DioChuks merged 3 commits intoStarkBid:mainfrom
YakshitAgarwal:feat-120-home-page

Conversation

@YakshitAgarwal
Copy link
Contributor

Closes #120

@netlify
Copy link

netlify bot commented Aug 3, 2025

Deploy Preview for starkbid ready!

Name Link
🔨 Latest commit a684413
🔍 Latest deploy log https://app.netlify.com/projects/starkbid/deploys/689b3066ea2f9f0008bcce4e
😎 Deploy Preview https://deploy-preview-141--starkbid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 3, 2025

Deploy Preview for starkbid-stable ready!

Name Link
🔨 Latest commit a684413
🔍 Latest deploy log https://app.netlify.com/projects/starkbid-stable/deploys/689b3066c8751900089e87be
😎 Deploy Preview https://deploy-preview-141--starkbid-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@YakshitAgarwal YakshitAgarwal marked this pull request as draft August 3, 2025 16:00
@DioChuks DioChuks self-requested a review August 4, 2025 11:07
@YakshitAgarwal YakshitAgarwal marked this pull request as ready for review August 4, 2025 17:09
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo the changes in this file.

</tbody>
</table>

{/*Mobile view */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the mobile view is scrollable on x-axis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to be be scrollable in x-axis the table should contain all the table headers but in the figma design the table headers contain only 3 things (#, collection, floor price)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was shown in the figma is a mere representation of what a scrollable table should look like, from header to its content. The reason for the header containing only 3 suggests that the entire table is scrollable on the x-axis. If u need help achieving that, try to go the /collections route and take a look at the one done there.

<Link href={'/auction'} className="absolute bottom-20 left-1/2 transform -translate-x-1/2 border border-soft_grey bg-white text-black px-4 py-2 rounded-md text-sm font-medium z-10 transition-all duration-300 opacity-100 shadow-md hover:bg-gray-100">
<Link
href={"/auction"}
className="absolute bottom-20 left-1/2 transform -translate-x-1/2 border border-soft_grey bg-white text-black px-4 py-2 rounded-md text-sm font-medium z-10 transition-all duration-300 opacity-100 shadow-md hover:bg-gray-100"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on mobile, this looks out of position, reduce font size to xs for smaller screen to ensure inline display.

@DioChuks DioChuks marked this pull request as draft August 5, 2025 14:00
@YakshitAgarwal
Copy link
Contributor Author

Hello @DioChuks ??

@DioChuks
Copy link
Contributor

@YakshitAgarwal no new changes have been added since last week

@YakshitAgarwal
Copy link
Contributor Author

@DioChuks I have made the required changes way back, I was just waiting for you to clarify the doubt I had regarding the x-axis scrollable table.

@YakshitAgarwal YakshitAgarwal marked this pull request as ready for review August 12, 2025 12:15
@DioChuks DioChuks merged commit 4a7afd3 into StarkBid:main Aug 12, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement or Edit home page mobile responsiveness and menu to match Figma design

2 participants