Skip to content

Feat: Carousel feature for live auction#150

Merged
DioChuks merged 4 commits intoStarkBid:mainfrom
YakshitAgarwal:feat-146-carousel
Sep 5, 2025
Merged

Feat: Carousel feature for live auction#150
DioChuks merged 4 commits intoStarkBid:mainfrom
YakshitAgarwal:feat-146-carousel

Conversation

@YakshitAgarwal
Copy link
Contributor

Closes #146

image

@netlify
Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for starkbid ready!

Name Link
🔨 Latest commit 2527f86
🔍 Latest deploy log https://app.netlify.com/projects/starkbid/deploys/68b83efd3663c000080b44e1
😎 Deploy Preview https://deploy-preview-150--starkbid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for starkbid-stable ready!

Name Link
🔨 Latest commit 2527f86
🔍 Latest deploy log https://app.netlify.com/projects/starkbid-stable/deploys/68b83efd67196c0008698b1f
😎 Deploy Preview https://deploy-preview-150--starkbid-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@DioChuks DioChuks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that requested change, great work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls ensure correct mobile responsiveness as expected!

Expected:

image

Current:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, on it right away!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this hasnt been resolved, the changes made are not what was expected

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit: 715c791

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on it!

Copy link
Contributor

@DioChuks DioChuks Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check your changes on both desktop & mobile. Fix the desktop bug
image

pls ensure to thoroughly check before pushing your changes

@YakshitAgarwal
Copy link
Contributor Author

Made the change, can you check?

@YakshitAgarwal
Copy link
Contributor Author

@DioChuks did you check?

Copy link
Contributor

@DioChuks DioChuks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

@DioChuks DioChuks merged commit 4afa15d into StarkBid:main Sep 5, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Carousel Functionality for "Live Auctions" Section

2 participants