Skip to content

fix and optimize sounds and music (on macos?) #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nnmrts wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix and optimize sounds and music (on macos?) #1216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3ad656
fix and optimize sounds and music (on macos?)
nnmrts Feb 18, 2026
7762196
revise RESTART_MUSIC patch
nnmrts Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion lovely/sound.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ elseif request.type == 'sound_source' then
SMODS_Sounds[request.sound_code] = {
sound_code = request.sound_code,
data = request.data,
sound = sound,
should_stream = request.should_stream,
per = request.per,
vol = request.vol,
}
Expand Down Expand Up @@ -131,6 +131,28 @@ match_indent = true
position = 'at'
payload = 'RESTART_MUSIC(request)'

[[patches]]
[patches.pattern]
target = 'engine/sound_manager.lua'
pattern = '''SOURCES[k] = {}
args.per = 0.7'''
match_indent = true
position = 'at'
payload = '''SOURCES[k] = {}
if not SMODS_Sounds[k] or k == args.desired_track then
args.per = 0.7'''

[[patches]]
[patches.pattern]
target = 'engine/sound_manager.lua'
pattern = '''local s = PLAY_SOUND(args)
s.initialized = true'''
match_indent = true
position = 'at'
payload = '''local s = PLAY_SOUND(args)
if s then s.initialized = true end
end'''

# fix looping for music of different length

[[patches]]
Expand Down