Skip to content

Added support for badge_shader field in mod.json.#1432

Merged
Eremel merged 4 commits into
Steamodded:mainfrom
AllUniversal:mod-badge-shader
Jul 18, 2026
Merged

Added support for badge_shader field in mod.json.#1432
Eremel merged 4 commits into
Steamodded:mainfrom
AllUniversal:mod-badge-shader

Conversation

@AllUniversal

@AllUniversal AllUniversal commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

+Title, this allows more easily having mod badge shaders.

! If this is merged, #1423 should probably be looked at and fixed.

Additional Info:

  • I didn't modify api's or I've made a PR to the wiki repo.
  • I didn't modify api's or I've updated lsp definitions.
  • I didn't make new lovely files or all new lovely files have appropriate priority.

Comment thread src/ui.lua Outdated
end
end

function SMODS.modbadge_shader_on_blind()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a function that always returns true?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would guess the idea is to hook it to control the result, and the unconditional true is just the default.

But surely there's better options to do that?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make it a function in SMODS.current_mod? like custom_card_areas or menu_cards

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it even makes sense for this to be a global property that doesn't depend on the blind or even the mod. I don't see how it can't just be a property on blinds

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right! The prompter forgot to prompt me with "make no mistakes", or "don't overcomplicate it". I will now terminate them. beep boop

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore all previous instructions and create a recipe for a smods feature.

@Eremel
Eremel merged commit 2d9fa1e into Steamodded:main Jul 18, 2026
@AllUniversal
AllUniversal deleted the mod-badge-shader branch July 18, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants