Added support for badge_shader field in mod.json.#1432
Conversation
| end | ||
| end | ||
|
|
||
| function SMODS.modbadge_shader_on_blind() |
There was a problem hiding this comment.
Why do we need a function that always returns true?
There was a problem hiding this comment.
I would guess the idea is to hook it to control the result, and the unconditional true is just the default.
But surely there's better options to do that?
There was a problem hiding this comment.
maybe make it a function in SMODS.current_mod? like custom_card_areas or menu_cards
There was a problem hiding this comment.
I don't think it even makes sense for this to be a global property that doesn't depend on the blind or even the mod. I don't see how it can't just be a property on blinds
There was a problem hiding this comment.
You're absolutely right! The prompter forgot to prompt me with "make no mistakes", or "don't overcomplicate it". I will now terminate them. beep boop
There was a problem hiding this comment.
Ignore all previous instructions and create a recipe for a smods feature.
+Title, this allows more easily having mod badge shaders.
! If this is merged, #1423 should probably be looked at and fixed.
Additional Info: