Adding Debug Switch to gallery extension#27
Open
seanmcne wants to merge 6 commits intoStefanKert:masterfrom
Open
Adding Debug Switch to gallery extension#27seanmcne wants to merge 6 commits intoStefanKert:masterfrom
seanmcne wants to merge 6 commits intoStefanKert:masterfrom
Conversation
adding debug/verbose when there is a debug switch enabled
Added enabledebugswitch for debug output
Added input for debug switch
updated to using 'boolean' and using getBoolInput
fixing type mismatch bug
Open
StefanKert
reviewed
Dec 5, 2020
|
|
||
| let signCertPassword: string = tl.getInput("signCertPassword", true); | ||
| let timeServer: string = tl.getInput("timeServer", true); | ||
| let enableDebugSwitch: boolean = tl.getBoolInput("enableDebugSwitch", true); |
Owner
There was a problem hiding this comment.
IMO this shouldn´t be required. Default value should be false. This should also fix the tests :)
let enableDebugSwitch: boolean = tl.getBoolInput("enableDebugSwitch", false);
StefanKert
reviewed
Dec 5, 2020
| tmr.setInput("timeServer", timeServer); | ||
| tmr.setInput("hashingAlgorithm", hashingAlgorithm); | ||
| tmr.setInput("files", filePaths); | ||
| tmr.setVariableName("SECURE_FILE_PATH", certificatePath); |
Owner
There was a problem hiding this comment.
Depending on if we keep the ui option or switch to a system.variable, we should set the information in this test and check if the required flags are actually set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.