feat: escrow module — multisig approvals, time-lock & rate limiting (#288) - #320
Open
A6dulmalik wants to merge 2 commits into
Open
feat: escrow module — multisig approvals, time-lock & rate limiting (#288)#320A6dulmalik wants to merge 2 commits into
A6dulmalik wants to merge 2 commits into
Conversation
…g (issue StellAIverse#288) - Escrow contract: configurable M-of-N signer approvals with admin management (add/remove signers, threshold, time-lock, grace period, rate limit, pause) all adjustable post-init - Multiple purpose-specific escrow instances (token or native with internal accounting) - Transaction queueing with submitter-as-first-approver; permissionless keeper execution gated by approvals + time-lock + grace window - Cancellation by admin/submitter anytime, by anyone after grace lapse - Sliding-window rate limiting per recipient and globally - Optional AccessControl integration: linked contract's Admin role can administer escrow via cross-contract has_role call - Events on init, deposits, queueing, approval, execution, cancellation, pause, config changes - 15 unit tests covering happy paths, all error branches and edge cases
Contributor
|
Weldone @A6dulmalik just run `Cargo fmt' and push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #288
Summary
New
contracts/escrowSoroban crate implementing the full escrow module:timelock_delayseconds and remain executable forgrace_period; afterwards they expire and become cancellable by anyone (garbage collection).create_escrow(token, is_native, purpose)mints independent purpose-specific escrow ids with per-instance balance accounting. Token escrows move SAC/ERC20-style tokens viaTokenClient; native escrows account internally.has_rolecall.Validation
cargo clippy -p escrow --all-targets: 0 errors / 0 warningscargo fmtapplied