feat(layout): mirror new IA in bottom-nav - #213
Open
samuel2926i39-art wants to merge 1 commit into
Open
Conversation
sidebar.tsx already groups navigation under the pivot IA (Overview, Assets, Wallets, Soroban, Rankings, Validators, Explorer), but bottom-nav.tsx (the mobile-web equivalent) still used the old flat 4-item list (Dashboard, Corridors, Anchors, Analytics), none of which line up with the new grouping. Bottom-nav has room for only a handful of tabs, so this surfaces one representative route per top-priority group instead of the full IA: Overview (/dashboard), Assets (/trustlines), Wallets (/wallet), Soroban (/soroban), and Rankings (/rankings) — matching the priority order called out in the issue and dropping Validators/Explorer, the same lower-priority groups sidebar.tsx demotes into its "explorer" section. Icons reuse the same lucide icons sidebar.tsx uses for each of these routes for visual consistency. Closes Stellar-Insightss#180
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sidebar.tsxalready groups navigation under the pivot information architecture (Overview, Assets, Wallets, Soroban, Rankings, Validators, Explorer — see itsnavGroups), butbottom-nav.tsx, the mobile-web equivalent, still used the old flat 4-item list (Dashboard, Corridors, Anchors, Analytics). None of those four map onto the new grouping, so mobile users saw a nav bar that no longer matched the desktop sidebar's structure.Bottom-nav only has room for a handful of tabs, so rather than trying to fit all 7 groups, this surfaces one representative route per top-priority group:
/dashboard/trustlines/wallet/soroban/rankingsValidators and Explorer are dropped from the bottom bar — the same two groups
sidebar.tsxtreats as lower-priority (Explorer is sidebar's demoted-utilities section), consistent with the issue's own guidance that Overview/Assets/Wallets/Soroban/Rankings "probably outrank Explorer on a small screen." Icons reuse the same lucide-react iconssidebar.tsxalready uses for each of these routes, for visual consistency between desktop and mobile nav.Before / after
All five routes already exist in
frontend/src/app/[locale]/(verified before writing the change).Testing
npx eslint src/components/layout/bottom-nav.tsx→ no errors./dashboard,/trustlines,/wallet,/soroban,/rankings) exists underfrontend/src/app/[locale]/so no tab points at a dead page.bottom-nav.tsx(nor does its siblingsidebar.tsx), so no new test convention was introduced here — kept consistent with the current layout component testing pattern (untested) rather than adding one-off coverage this folder doesn't otherwise have.Scope note
This only changes the nav item list and its icons/labels; the component's structure, active-state logic, and styling are untouched.
Closes #180