fix: improve transaction compatibility and harden Stellar tools validation#31
Open
Feyzanur25 wants to merge 2 commits intoStellar-Tools:mainfrom
Open
fix: improve transaction compatibility and harden Stellar tools validation#31Feyzanur25 wants to merge 2 commits intoStellar-Tools:mainfrom
Feyzanur25 wants to merge 2 commits intoStellar-Tools:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves transaction signing compatibility, TypeScript safety, and the overall reliability of multiple Stellar tools within AgentKit.
Changes
Transaction Handling
txXDRandnetworkPassphraseEnvironment Validation
STELLAR_PRIVATE_KEYandSTELLAR_PUBLIC_KEY!) on environment variablesBridge Tool Improvements
Liquidity Contract Tool Fixes
voidreturn valuesz.infer<typeof schema>Staking Contract Tool Fixes
voidreturn values in contract callsanyusage in error handlingTypeScript & Code Quality
anywith saferunknownerror handling patternsTechnical Impact
Notes
This PR focuses on improving both runtime safety and developer experience while aligning the codebase with current best practices for Stellar and TypeScript-based tooling.
Summary by cubic
Improves Stellar transaction signing and tool reliability with stronger runtime validation and a unified transaction builder. Adds
AgentClientexport and ensures compatibility with newer Stellar SDK versions.New Features
buildTransactionutility (with XDR support) to standardize fees, timeouts, and memos across tools; includes tests.AgentClientfromindexto simplify usage.Bug Fixes
STELLAR_PRIVATE_KEY,txXDR, andnetworkPassphrase; switch toTransaction.fromXDRfor safer parsing.STELLAR_PUBLIC_KEYandSTELLAR_PRIVATE_KEYto prevent runtime crashes.voidhandling, tightened input schemas (zod), and clarified control flow and responses.voidhandling, improved validation for initialize/stake/unstake/claim flows, and removed unsafeany.Written for commit 2da0744. Summary will update on new commits.