fix: improve transaction compatibility and tool safety#32
Open
Feyzanur25 wants to merge 2 commits intoStellar-Tools:mainfrom
Open
fix: improve transaction compatibility and tool safety#32Feyzanur25 wants to merge 2 commits intoStellar-Tools:mainfrom
Feyzanur25 wants to merge 2 commits intoStellar-Tools:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves transaction compatibility, TypeScript safety, and the reliability of multiple Stellar tools within AgentKit.
Changes
Transaction Handling
lib/stellar.tsContract & Tool Integration
TypeScript & Code Quality
funchandlersanyusage with saferunknownz.infer<typeof schema>Environment Safety
STELLAR_PUBLIC_KEYandSTELLAR_PRIVATE_KEYImpact
Summary by cubic
Improves Stellar transaction compatibility and tool safety across contract, bridge, and staking flows. Unifies Soroban XDR handling, enforces env checks, and tightens types to avoid crashes.
Bug Fixes
stellar-sdk; clear errors for missing keys and passphrase.ScValsafely, return native values (bigint), and surface pending status with hash.buildTransactionFromXDR; only setsSRBwhen provided; blocks mainnet unlessALLOW_MAINNET_BRIDGE=true.zodschemas,unknownoverany, fail fast on missingSTELLAR_PUBLIC_KEY, and clearer error messages.Migration
STELLAR_PUBLIC_KEYandSTELLAR_PRIVATE_KEY; tools now fail fast if missing.SRB_PROVIDER_URLfor@allbridge/bridge-core-sdk;ALLOW_MAINNET_BRIDGE=trueto enable mainnet bridging.Written for commit d1f44e7. Summary will update on new commits.