fix: resolve 7 TypeScript compilation errors blocking tsc --noEmit#50
fix: resolve 7 TypeScript compilation errors blocking tsc --noEmit#50Shantanu112-bd wants to merge 1 commit into
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | - | Generic Password | 0db6861 | tools/stellar.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
d448806 to
0db6861
Compare
|
resolve merge conflicts |
Summary
Fixes all 7 TypeScript compilation errors that caused
npx tsc --noEmitto fail, blocking IDE integrationand CI type-checking pipelines.
Changes
agent.ts
Serverimport →Horizon.Server(correctstellar-sdk v11+ pattern)
Networktype union to fix TS2367non-overlapping string comparison errors
examples/
error: unknownwithinstanceof Errorguard — eliminates implicit anylib/buildTransaction.ts
type guards
Verification
Closes #49
Summary by cubic
Fixes seven TypeScript errors so
npx tsc --noEmitpasses and adds full network-aware Soroban/Horizon config across libs/tools. Bridge and contract/stake tools now support multi-chain/token flows with stricter schemas and better errors; all 28 tests pass.New Features
ContractConfig/StakeConfigandnetworkPassphraseinbuildTransaction;AgentClientinjects Soroban config viagetSorobanConfigfor all contract ops.bridgeTokenToolto acceptdestinationChainandsymbolwith dynamic token lookup; wrapped in try/catch with clearer failures; mainnet guard preserved.fromNetworkand builds per-network RPC/passphrase;stellarSendPaymentToolrespectsSTELLAR_NETWORK;signTransactionaccepts an explicit secret key.Bug Fixes
Horizon.Serverfrom@stellar/stellar-sdk, typed balances withHorizon.ServerApi.BalanceLine, fixed TS2367 comparisons, and typedcatchblocks asunknown; tests updated.fromXDR.Written for commit 0db6861. Summary will update on new commits.