feat: add expire_match with configurable ledger timeout to unblock stuck funds#316
Merged
famvilianity-eng merged 2 commits intoStellarCheckMate:mainfrom Mar 30, 2026
Conversation
|
@Sundriveauto Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #281
Problem
If player1 creates a match and deposits but player2 never deposits, player1's funds are locked indefinitely with no way to reclaim them.
Changes
types.rsDataKey::MatchTimeoutvariant for storing a configurable timeout valueerrors.rsError::MatchNotExpired = 12returned whenexpire_matchis called too earlylib.rsDEFAULT_MATCH_TIMEOUT_LEDGERS = 17_280(~24 hours at 5s/ledger)expire_match(match_id): callable by anyone onceenv.ledger().sequence() - m.created_ledger >= timeout. Refunds any deposited stakes and transitions the match toCancelled. Timeout is read fromDataKey::MatchTimeoutwith fallback to the default constant.tests.rstest_expire_match_refunds_depositor_after_timeout: verifies player1 gets their stake back after the timeout elapsestest_expire_match_fails_before_timeout: verifiesError::MatchNotExpiredis returned if called too early