Skip to content

Fix/260 263 get oracle and player address tests#320

Merged
famvilianity-eng merged 1 commit intoStellarCheckMate:mainfrom
maztah1:fix/260-263-get-oracle-and-player-address-tests
Mar 30, 2026
Merged

Fix/260 263 get oracle and player address tests#320
famvilianity-eng merged 1 commit intoStellarCheckMate:mainfrom
maztah1:fix/260-263-get-oracle-and-player-address-tests

Conversation

@maztah1
Copy link
Copy Markdown
Contributor

@maztah1 maztah1 commented Mar 30, 2026

closes #260
closes #263

Summary

Changes

get_oracle getter (fix #260)

  • Added get_oracle(env: Env) -> Result<Address, Error> to EscrowContract
  • Reads DataKey::Oracle from instance storage, consistent with the existing get_admin pattern
  • Allows frontends and integrators to verify the trusted oracle without reading raw storage

Tests (fix #263 + #260)

  • test_get_oracle_returns_initialized_address — asserts get_oracle returns the address passed to
    initialize
  • test_get_match_returns_correct_players — asserts get_match returns the correct player1 and
    player2 addresses after match creation

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 30, 2026

@maztah1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@maztah1 maztah1 force-pushed the fix/260-263-get-oracle-and-player-address-tests branch 2 times, most recently from 969b1e6 to 78c051e Compare March 30, 2026 13:19
…te#263): assert get_match returns correct player addresses; fix: update snapshots with created_ledger field
@maztah1 maztah1 force-pushed the fix/260-263-get-oracle-and-player-address-tests branch from 7f77e44 to 3b7fed4 Compare March 30, 2026 13:35
@famvilianity-eng famvilianity-eng merged commit 272ca6d into StellarCheckMate:main Mar 30, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Test: get_match returns correct player1 and player2 addresses Fix: no way to retrieve the current oracle address from escrow contract

2 participants