Skip to content

fix: Standardized the events emitted by backend tools #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samjay8 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Standardized the events emitted by backend tools #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions contracts/price-oracle/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,8 @@ pub struct PriceOracle;
pub struct PriceUpdatedEvent {
pub asset: Symbol,
pub price: i128,
pub timestamp: u64,
pub relayer: Address,
}

#[soroban_sdk::contractevent]
Expand Down Expand Up @@ -1042,7 +1044,15 @@ impl PriceOracle {
current.timestamp = now;
storage.set(&key, &current);
update_twap(&env, asset.clone(), val, now);
env.events().publish_event(&PriceUpdatedEvent { asset: asset.clone(), price: val });
env.events().publish(
(Symbol::new(&env, "price_updated"), asset.clone()),
PriceUpdatedEvent {
asset: asset.clone(),
price: val,
timestamp: now,
relayer: env.current_contract_address(),
},
);
log_event(&env, Symbol::new(&env, "price_updated"), asset, val);
return Ok(());
}
Expand All @@ -1066,10 +1076,15 @@ impl PriceOracle {
log_event(&env, Symbol::new(&env, "asset_added"), asset.clone(), normalized);
} else {
log_event(&env, Symbol::new(&env, "price_updated"), asset.clone(), normalized);
env.events().publish_event(&PriceUpdatedEvent {
asset: asset.clone(),
price: normalized,
});
env.events().publish(
(Symbol::new(&env, "price_updated"), asset.clone()),
PriceUpdatedEvent {
asset: asset.clone(),
price: normalized,
timestamp: now,
relayer: env.current_contract_address(),
},
);
}

// Notify subscribers of the price update
Expand Down Expand Up @@ -1353,7 +1368,16 @@ impl PriceOracle {
storage.set(&key, &price_data);
update_twap(&env, asset.clone(), median_price, env.ledger().timestamp());

env.events().publish_event(&PriceUpdatedEvent { asset: asset.clone(), price: normalized });
let now = env.ledger().timestamp();
env.events().publish(
(Symbol::new(&env, "price_updated"), asset.clone()),
PriceUpdatedEvent {
asset: asset.clone(),
price: median_price,
timestamp: now,
relayer: source.clone(),
},
);
log_event(&env, Symbol::new(&env, "price_updated"), asset.clone(), normalized);

// Notify all subscribed contracts of the price update
Expand Down