Add event when pause/unpause toggles include actor role#320
Merged
Conversation
Junman140
changed the title
|
@Junman140 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Junman140 Check and resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #268
What changed
Added a new enriched pause lifecycle event emerg_v2 that includes an actor role hint (admin / operator) in event data, in soroban-contracts/contracts/single_rwa_vault/src/events.rs.
On pause/unpause/emergency_withdraw, the contract now emits:
New emerg_v2 event: (paused, reason, actor_role)
Existing emergency event unchanged: (paused, reason)
Backward-compat behavior: emerg_v2 is emitted first, then emergency, so listeners that only look at the “last” event still see the legacy emergency event.
Fixed a build blocker: removed a duplicate storage_schema_version definition in soroban-contracts/contracts/single_rwa_vault/src/lib.rs (it existed twice and broke compilation).
Where to look
New event emitter: soroban-contracts/contracts/single_rwa_vault/src/events.rs (emit_emergency_action_v2)
Updated pause/unpause/emergency_withdraw: soroban-contracts/contracts/single_rwa_vault/src/lib.rs
Verification
cargo test -p single_rwa_vault now passes (306 passed; 0 failed).