Issue 007 expose vercel build logs via deployment logs service#506
Open
midenotch wants to merge 2 commits intoStellerCraft:mainfrom
Open
Conversation
|
@midenotch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
Done, Close: #506 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #481
I have successfully exposed Vercel build logs via the DeploymentLogsService and updated the logs API route.
Summary of Changes
DeploymentLogsService:
Added 'build' to the VALID_STAGES constant to allow filtering by the build phase.
Implemented the syncVercelLogs(deploymentId, supabase) method. This method fetches the vercel_deployment_id from the database, retrieves the logs from Vercel using VercelService, and upserts them into the deployment_logs table.
Used a deterministic ID prefix (vlc_) for synced logs to prevent duplicate entries across multiple requests.
Logs API Route:
Updated the GET /api/deployments/[id]/logs route to automatically trigger syncVercelLogs whenever the stage=build query parameter is provided.
This ensures that the build progress displayed to the user is always up-to-date with Vercel's state.
Testing:
Added new test cases to route.test.ts to verify that requesting the build stage correctly triggers the synchronization logic while other stages remain unaffected.
Verified all 12 tests in the suite pass.