Skip to content

Changes made #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Malcolm-Wander wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changes made #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
190 changes: 190 additions & 0 deletions apps/backend/src/app/api/deployments/route.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,23 @@ function makeTableMock(results: { data: unknown; error: unknown; count?: number
};
}

function get(url: string, headers?: Record<string, string>) {
return new NextRequest(url, {
method: 'GET',
headers: headers ?? {},
});
}

function postWithVersion(url: string, body: unknown, version?: string) {
const headers: Record<string, string> = { 'Content-Type': 'application/json' };
if (version) headers['API-Version'] = version;
return new NextRequest(url, {
method: 'POST',
headers,
body: JSON.stringify(body),
});
}

describe('POST /api/deployments', () => {
beforeEach(() => {
vi.clearAllMocks();
Expand Down Expand Up @@ -199,3 +216,176 @@ describe('POST /api/deployments', () => {
expect(body.status).toBe('generating');
});
});

describe('GET /api/deployments', () => {
beforeEach(() => {
vi.clearAllMocks();
mockGetUser.mockResolvedValue({ data: { user: fakeUser }, error: null });
});

it('returns 401 when unauthenticated', async () => {
mockGetUser.mockResolvedValue({ data: { user: null }, error: null });
const { GET } = await import('./route');
const res = await GET(get('http://localhost/api/deployments'), { params: {} as any });
expect(res.status).toBe(401);
});

it('returns user deployments', async () => {
const deploymentRows = [
{ id: 'dep-1', name: 'App 1', status: 'deployed', template_id: 'tpl-1', created_at: '2024-01-01', updated_at: '2024-01-02', deployed_at: '2024-01-02', deployment_url: 'https://app-1.vercel.app' },
];
mockFrom.mockImplementation((table: string) => {
if (table === 'deployments') {
return {
select: vi.fn(() => ({
eq: vi.fn(() => ({
order: vi.fn().mockResolvedValue({ data: deploymentRows, error: null }),
})),
})),
};
}
return makeTableMock([]);
});
const { GET } = await import('./route');
const res = await GET(get('http://localhost/api/deployments'), { params: {} as any });
expect(res.status).toBe(200);
const body = await res.json();
expect(body.deployments).toHaveLength(1);
expect(body.deployments[0].id).toBe('dep-1');
expect(body.deployments[0].templateId).toBe('tpl-1');
});

it('returns 500 when supabase query fails', async () => {
mockFrom.mockImplementation((table: string) => {
if (table === 'deployments') {
return {
select: vi.fn(() => ({
eq: vi.fn(() => ({
order: vi.fn().mockResolvedValue({ data: null, error: { message: 'db error' } }),
})),
})),
};
}
return makeTableMock([]);
});
const { GET } = await import('./route');
const res = await GET(get('http://localhost/api/deployments'), { params: {} as any });
expect(res.status).toBe(500);
});
});

describe('API versioning on /api/deployments', () => {
beforeEach(() => {
vi.clearAllMocks();
mockGetUser.mockResolvedValue({ data: { user: fakeUser }, error: null });
});

it('includes X-API-Version header in response', async () => {
mockFrom.mockImplementation((table: string) => {
if (table === 'deployments') {
return {
select: vi.fn(() => ({
eq: vi.fn(() => ({
order: vi.fn().mockResolvedValue({ data: [], error: null }),
})),
})),
};
}
return makeTableMock([]);
});
const { GET } = await import('./route');
const res = await GET(get('http://localhost/api/deployments'), { params: {} as any });
expect(res.headers.get('X-API-Version')).toBe('v1');
});

it('includes X-Latest-Version header in response', async () => {
mockFrom.mockImplementation((table: string) => {
if (table === 'deployments') {
return {
select: vi.fn(() => ({
eq: vi.fn(() => ({
order: vi.fn().mockResolvedValue({ data: [], error: null }),
})),
})),
};
}
return makeTableMock([]);
});
const { GET } = await import('./route');
const res = await GET(get('http://localhost/api/deployments'), { params: {} as any });
expect(res.headers.get('X-Latest-Version')).toBe('v1');
});

it('defaults to v1 when API-Version header is absent', async () => {
mockFrom.mockImplementation((table: string) => {
if (table === 'deployments') {
return {
select: vi.fn(() => ({
eq: vi.fn(() => ({
order: vi.fn().mockResolvedValue({ data: [], error: null }),
})),
})),
};
}
return makeTableMock([]);
});
const { GET } = await import('./route');
const res = await GET(get('http://localhost/api/deployments'), { params: {} as any });
expect(res.headers.get('X-API-Version')).toBe('v1');
expect(res.status).toBe(200);
});

it('accepts API-Version: v1 explicitly', async () => {
mockFrom.mockImplementation((table: string) => {
if (table === 'deployments') {
return {
select: vi.fn(() => ({
eq: vi.fn(() => ({
order: vi.fn().mockResolvedValue({ data: [], error: null }),
})),
})),
};
}
return makeTableMock([]);
});
const { GET } = await import('./route');
const res = await GET(get('http://localhost/api/deployments', { 'API-Version': 'v1' }), { params: {} as any });
expect(res.status).toBe(200);
expect(res.headers.get('X-API-Version')).toBe('v1');
});

it('returns 400 with supportedVersions for unknown version', async () => {
const { GET } = await import('./route');
const res = await GET(get('http://localhost/api/deployments', { 'API-Version': 'v99' }), { params: {} as any });
expect(res.status).toBe(400);
const body = await res.json();
expect(body.error).toMatch(/Unsupported API version/);
expect(body.supportedVersions).toEqual(['v1']);
});

it('does not set Deprecation header for current version (v1)', async () => {
mockFrom.mockImplementation((table: string) => {
if (table === 'deployments') {
return {
select: vi.fn(() => ({
eq: vi.fn(() => ({
order: vi.fn().mockResolvedValue({ data: [], error: null }),
})),
})),
};
}
return makeTableMock([]);
});
const { GET } = await import('./route');
const res = await GET(get('http://localhost/api/deployments', { 'API-Version': 'v1' }), { params: {} as any });
expect(res.headers.get('Deprecation')).toBeNull();
});

it('returns 400 with supportedVersions for unknown POST version', async () => {
const { POST } = await import('./route');
const res = await POST(postWithVersion('http://localhost/api/deployments', { templateId: 'tpl-1' }, 'v99'), { params: {} as any });
expect(res.status).toBe(400);
const body = await res.json();
expect(body.supportedVersions).toEqual(['v1']);
});
});
Loading