Skip to content

feat: customisation studio layout#526

Merged
temma02 merged 1 commit intoStellerCraft:mainfrom
lyon-1050:feature/issue-16-customisation-studio-layout
Apr 29, 2026
Merged

feat: customisation studio layout#526
temma02 merged 1 commit intoStellerCraft:mainfrom
lyon-1050:feature/issue-16-customisation-studio-layout

Conversation

@lyon-1050
Copy link
Copy Markdown
Contributor

What was implemented

  1. CustomizationStudio.test.tsx — duplicate text match

When saveState is 'saving', the text "Saving…" appeared in two
places: the status and the Save . screen.getByText
throws when it finds multiple matches. Fixed by switching to
getAllByText(...).length > 0.

  1. useCustomizationStudio.test.ts — waitFor timeouts with fake
    timers

vi.useFakeTimers() was applied globally in beforeEach, which froze
the microtask queue and caused waitFor (which polls via setTimeout
internally) to hang indefinitely. Fixed by removing the global
fake timer setup and only enabling fake timers (with {
shouldAdvanceTime: true }) in the single test that actually needs
them — the auto-save debounce test — then restoring real timers
immediately after.

closes #16

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Apr 29, 2026

@lyon-1050 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@temma02 temma02 merged commit a3e51c8 into StellerCraft:main Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue 016: Design the customization studio layout

2 participants