Feat/scheduler by khanhdo05 · Pull Request #111 · StressLess-Team/StressLess

khanhdo05 · 2025-05-08T05:08:38Z

Non-breaking changes, can be merged into dev then keep working on scheduling logic.

tyu012

I am leaving some comments that might want to be addressed.

backend/src/utils/Scheduler.ts

tyu012 · 2025-05-08T16:02:20Z

backend/src/utils/Scheduler.ts

+          console.warn("This event does not have end time, eventId: " + event.id);
+          continue;
+        }
+        total_events_duration_for_a_deadline += UserPreferenceUtils.dateToMinuteNumber(event.end_time) - UserPreferenceUtils.dateToMinuteNumber(event.start_time);


We can just perform this operation with the Date objects: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date#calculating_elapsed_time

This would resolve the edge case of whether an event spans across midnight.

Also, remember to use camel case in TypeScript

tyu012 · 2025-05-08T16:11:12Z

backend/src/utils/Scheduler.ts

+    const dayEnd = userPreferences.endTime;
+    const minIncrement = 5;
+
+    while (UserPreferenceUtils.dateToMinuteNumber(checkTime) <= dayEnd) {


Can use a for loop

tyu012 · 2025-05-08T16:19:07Z

backend/src/utils/Scheduler.ts

      currentMinutes >= userPreferences.startTime &&
-        currentMinutes + userPreferences.workDuration <= userPreferences.endTime
-    );
+      currentMinutes + userPreferences.workDuration <= userPreferences.endTime;


I am not sure if we need to add workDuration. Maybe a minimum work duration of 5 minutes instead as a workaround?

then we are not considering the work duration at all. i guess we can do + min(workDuration, projected_duration)

Changed to the following:

const isWithinWorkHours = currentMinutes >= userPreferences.startTime && currentMinutes <= userPreferences.endTime;

tyu012 · 2025-05-08T16:20:59Z

backend/src/utils/Scheduler.ts

+        event &&
+        (event.start_time == undefined ||
+          event.end_time == undefined ||
+          (event.start_time <= time && event.end_time > time))


If start time or end time is undefined, I think that we should exclude the event from the events at a given time.

I might have written this wrong when I initially wrote this.

tyu012 · 2025-05-08T16:32:26Z

backend/src/utils/Scheduler.ts

+      );
    }

    return dayEnd - currentMinutes;


In general about this function, this is not filtering by events that occur within the current day first.

tyu012 · 2025-05-08T16:33:20Z

backend/src/utils/Scheduler.ts

+   * @param deadlineId A deadline_id to match to event
+   * @private
+   */
+  private static getEventByDeadlineId(events: UserEvent[], deadlineId: string) {


Can specify return type now

Also, functions can be renamed getEventsByDeadlineId with events being plural since we are returning multiple events.

tyu012 · 2025-05-08T16:40:58Z

backend/src/utils/Scheduler.ts

+        const freeBlock = this.nextFreeTimeBlock([...events, ...scheduledEvents], userPreferences, currentTime);
+
+        // No available block left today
+        if (!freeBlock) break;


We should probably try again at the next day (if the deadline is not due by then).

We didn't ask which work day users prefer, so should we default to M-F or 7 days a week (the latter is more useful for college students in my opinion)

tyu012 · 2025-05-08T16:42:52Z

backend/src/utils/Scheduler.ts

    userPreferences: UserPreferences
  ): SchedulerOutput {
+    const scheduledEvents: UserEvent[] = [];
+    const deadlineRemainders = this.calculateDeadlineRemainders(events, deadlines);


Sorting by priority may be useful

oh true i forgot to consider that field completely

I will leave this as a to-do since priority is a string

tyu012

I have implemented most of the commented changes; I will approve the PR.

tyu012 · 2025-05-08T21:14:21Z

backend/src/utils/Scheduler.ts

    userPreferences: UserPreferences
  ): SchedulerOutput {
+    const scheduledEvents: UserEvent[] = [];
+    const deadlineRemainders = this.calculateDeadlineRemainders(events, deadlines);


I will leave this as a to-do since priority is a string

tyu012 · 2025-05-08T21:33:01Z

backend/src/utils/Scheduler.ts

      currentMinutes >= userPreferences.startTime &&
-        currentMinutes + userPreferences.workDuration <= userPreferences.endTime
-    );
+      currentMinutes + userPreferences.workDuration <= userPreferences.endTime;


Changed to the following:

const isWithinWorkHours = currentMinutes >= userPreferences.startTime && currentMinutes <= userPreferences.endTime;

backend/src/utils/Scheduler.ts

tyu012 · 2025-05-08T22:51:38Z

I have implemented most of the commented changes; I will approve the PR.

khanhdo05 added 2 commits May 7, 2025 23:34

finish logic for calculateDeadlineRemainders

0cbb4c1

Finish scheduling logic and fix controller to not include idin new event

cfd91f5

khanhdo05 requested a review from tyu012 May 8, 2025 05:08

tyu012 reviewed May 8, 2025

View reviewed changes

Added some fixes to scheduler and accounted for more edge cases

5721e9a

tyu012 reviewed May 8, 2025

View reviewed changes

tyu012 merged commit a078e40 into development May 8, 2025
1 check passed

trappaly deleted the feat/scheduler branch May 14, 2025 23:03

Conversation

khanhdo05 commented May 8, 2025

Uh oh!

tyu012 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tyu012 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tyu012 commented May 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants